1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649
// Copyright 2019 Parity Technologies (UK) Ltd. // // Permission is hereby granted, free of charge, to any person obtaining a // copy of this software and associated documentation files (the "Software"), // to deal in the Software without restriction, including without limitation // the rights to use, copy, modify, merge, publish, distribute, sublicense, // and/or sell copies of the Software, and to permit persons to whom the // Software is furnished to do so, subject to the following conditions: // // The above copyright notice and this permission notice shall be included in // all copies or substantial portions of the Software. // // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS // OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING // FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER // DEALINGS IN THE SOFTWARE. //! The internal API for a single `KBucket` in a `KBucketsTable`. //! //! > **Note**: Uniqueness of entries w.r.t. a `Key` in a `KBucket` is not //! > checked in this module. This is an invariant that must hold across all //! > buckets in a `KBucketsTable` and hence is enforced by the public API //! > of the `KBucketsTable` and in particular the public `Entry` API. pub use crate::K_VALUE; use super::*; /// A `PendingNode` is a `Node` that is pending insertion into a `KBucket`. #[derive(Debug, Clone)] pub struct PendingNode<TKey, TVal> { /// The pending node to insert. node: Node<TKey, TVal>, /// The status of the pending node. status: NodeStatus, /// The instant at which the pending node is eligible for insertion into a bucket. replace: Instant, } /// The status of a node in a bucket. /// /// The status of a node in a bucket together with the time of the /// last status change determines the position of the node in a /// bucket. #[derive(PartialEq, Eq, Debug, Copy, Clone)] pub enum NodeStatus { /// The node is considered connected. Connected, /// The node is considered disconnected. Disconnected } impl<TKey, TVal> PendingNode<TKey, TVal> { pub fn key(&self) -> &TKey { &self.node.key } pub fn status(&self) -> NodeStatus { self.status } pub fn value_mut(&mut self) -> &mut TVal { &mut self.node.value } pub fn is_ready(&self) -> bool { Instant::now() >= self.replace } pub fn set_ready_at(&mut self, t: Instant) { self.replace = t; } pub fn into_node(self) -> Node<TKey, TVal> { self.node } } /// A `Node` in a bucket, representing a peer participating /// in the Kademlia DHT together with an associated value (e.g. contact /// information). #[derive(Debug, Clone, PartialEq, Eq)] pub struct Node<TKey, TVal> { /// The key of the node, identifying the peer. pub key: TKey, /// The associated value. pub value: TVal, } /// The position of a node in a `KBucket`, i.e. a non-negative integer /// in the range `[0, K_VALUE)`. #[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] pub struct Position(usize); /// A `KBucket` is a list of up to `K_VALUE` keys and associated values, /// ordered from least-recently connected to most-recently connected. #[derive(Debug, Clone)] pub struct KBucket<TKey, TVal> { /// The nodes contained in the bucket. nodes: ArrayVec<[Node<TKey, TVal>; K_VALUE.get()]>, /// The position (index) in `nodes` that marks the first connected node. /// /// Since the entries in `nodes` are ordered from least-recently connected to /// most-recently connected, all entries above this index are also considered /// connected, i.e. the range `[0, first_connected_pos)` marks the sub-list of entries /// that are considered disconnected and the range /// `[first_connected_pos, K_VALUE)` marks sub-list of entries that are /// considered connected. /// /// `None` indicates that there are no connected entries in the bucket, i.e. /// the bucket is either empty, or contains only entries for peers that are /// considered disconnected. first_connected_pos: Option<usize>, /// A node that is pending to be inserted into a full bucket, should the /// least-recently connected (and currently disconnected) node not be /// marked as connected within `unresponsive_timeout`. pending: Option<PendingNode<TKey, TVal>>, /// The timeout window before a new pending node is eligible for insertion, /// if the least-recently connected node is not updated as being connected /// in the meantime. pending_timeout: Duration } /// The result of inserting an entry into a bucket. #[must_use] #[derive(Debug, Clone, PartialEq, Eq)] pub enum InsertResult<TKey> { /// The entry has been successfully inserted. Inserted, /// The entry is pending insertion because the relevant bucket is currently full. /// The entry is inserted after a timeout elapsed, if the status of the /// least-recently connected (and currently disconnected) node in the bucket /// is not updated before the timeout expires. Pending { /// The key of the least-recently connected entry that is currently considered /// disconnected and whose corresponding peer should be checked for connectivity /// in order to prevent it from being evicted. If connectivity to the peer is /// re-established, the corresponding entry should be updated with /// [`NodeStatus::Connected`]. disconnected: TKey }, /// The entry was not inserted because the relevant bucket is full. Full } /// The result of applying a pending node to a bucket, possibly /// replacing an existing node. #[derive(Debug, Clone, PartialEq, Eq)] pub struct AppliedPending<TKey, TVal> { /// The key of the inserted pending node. pub inserted: Node<TKey, TVal>, /// The node that has been evicted from the bucket to make room for the /// pending node, if any. pub evicted: Option<Node<TKey, TVal>> } impl<TKey, TVal> KBucket<TKey, TVal> where TKey: Clone + AsRef<KeyBytes>, TVal: Clone { /// Creates a new `KBucket` with the given timeout for pending entries. pub fn new(pending_timeout: Duration) -> Self { KBucket { nodes: ArrayVec::new(), first_connected_pos: None, pending: None, pending_timeout, } } /// Returns a reference to the pending node of the bucket, if there is any. pub fn pending(&self) -> Option<&PendingNode<TKey, TVal>> { self.pending.as_ref() } /// Returns a mutable reference to the pending node of the bucket, if there is any. pub fn pending_mut(&mut self) -> Option<&mut PendingNode<TKey, TVal>> { self.pending.as_mut() } /// Returns a reference to the pending node of the bucket, if there is any /// with a matching key. pub fn as_pending(&self, key: &TKey) -> Option<&PendingNode<TKey, TVal>> { self.pending().filter(|p| p.node.key.as_ref() == key.as_ref()) } /// Returns a reference to a node in the bucket. pub fn get(&self, key: &TKey) -> Option<&Node<TKey, TVal>> { self.position(key).map(|p| &self.nodes[p.0]) } /// Returns an iterator over the nodes in the bucket, together with their status. pub fn iter(&self) -> impl Iterator<Item = (&Node<TKey, TVal>, NodeStatus)> { self.nodes.iter().enumerate().map(move |(p, n)| (n, self.status(Position(p)))) } /// Inserts the pending node into the bucket, if its timeout has elapsed, /// replacing the least-recently connected node. /// /// If a pending node has been inserted, its key is returned together with /// the node that was replaced. `None` indicates that the nodes in the /// bucket remained unchanged. pub fn apply_pending(&mut self) -> Option<AppliedPending<TKey, TVal>> { if let Some(pending) = self.pending.take() { if pending.replace <= Instant::now() { if self.nodes.is_full() { if self.status(Position(0)) == NodeStatus::Connected { // The bucket is full with connected nodes. Drop the pending node. return None } debug_assert!(self.first_connected_pos.map_or(true, |p| p > 0)); // (*) // The pending node will be inserted. let inserted = pending.node.clone(); // A connected pending node goes at the end of the list for // the connected peers, removing the least-recently connected. if pending.status == NodeStatus::Connected { let evicted = Some(self.nodes.remove(0)); self.first_connected_pos = self.first_connected_pos .map_or_else( | | Some(self.nodes.len()), |p| p.checked_sub(1)); self.nodes.push(pending.node); return Some(AppliedPending { inserted, evicted }) } // A disconnected pending node goes at the end of the list // for the disconnected peers. else if let Some(p) = self.first_connected_pos { let insert_pos = p.checked_sub(1).expect("by (*)"); let evicted = Some(self.nodes.remove(0)); self.nodes.insert(insert_pos, pending.node); return Some(AppliedPending { inserted, evicted }) } else { // All nodes are disconnected. Insert the new node as the most // recently disconnected, removing the least-recently disconnected. let evicted = Some(self.nodes.remove(0)); self.nodes.push(pending.node); return Some(AppliedPending { inserted, evicted }) } } else { // There is room in the bucket, so just insert the pending node. let inserted = pending.node.clone(); match self.insert(pending.node, pending.status) { InsertResult::Inserted => return Some(AppliedPending { inserted, evicted: None }), _ => unreachable!("Bucket is not full.") } } } else { self.pending = Some(pending); } } return None } /// Updates the status of the pending node, if any. pub fn update_pending(&mut self, status: NodeStatus) { if let Some(pending) = &mut self.pending { pending.status = status } } /// Removes the pending node from the bucket, if any. pub fn remove_pending(&mut self) -> Option<PendingNode<TKey, TVal>> { self.pending.take() } /// Updates the status of the node referred to by the given key, if it is /// in the bucket. pub fn update(&mut self, key: &TKey, status: NodeStatus) { // Remove the node from its current position and then reinsert it // with the desired status, which puts it at the end of either the // prefix list of disconnected nodes or the suffix list of connected // nodes (i.e. most-recently disconnected or most-recently connected, // respectively). if let Some((node, _status, pos)) = self.remove(key) { // If the least-recently connected node re-establishes its // connected status, drop the pending node. if pos == Position(0) && status == NodeStatus::Connected { self.pending = None } // Reinsert the node with the desired status. match self.insert(node, status) { InsertResult::Inserted => {}, _ => unreachable!("The node is removed before being (re)inserted.") } } } /// Inserts a new node into the bucket with the given status. /// /// The status of the node to insert determines the result as follows: /// /// * `NodeStatus::Connected`: If the bucket is full and either all nodes are connected /// or there is already a pending node, insertion fails with `InsertResult::Full`. /// If the bucket is full but at least one node is disconnected and there is no pending /// node, the new node is inserted as pending, yielding `InsertResult::Pending`. /// Otherwise the bucket has free slots and the new node is added to the end of the /// bucket as the most-recently connected node. /// /// * `NodeStatus::Disconnected`: If the bucket is full, insertion fails with /// `InsertResult::Full`. Otherwise the bucket has free slots and the new node /// is inserted at the position preceding the first connected node, /// i.e. as the most-recently disconnected node. If there are no connected nodes, /// the new node is added as the last element of the bucket. /// pub fn insert(&mut self, node: Node<TKey, TVal>, status: NodeStatus) -> InsertResult<TKey> { match status { NodeStatus::Connected => { if self.nodes.is_full() { if self.first_connected_pos == Some(0) || self.pending.is_some() { return InsertResult::Full } else { self.pending = Some(PendingNode { node, status: NodeStatus::Connected, replace: Instant::now() + self.pending_timeout, }); return InsertResult::Pending { disconnected: self.nodes[0].key.clone() } } } let pos = self.nodes.len(); self.first_connected_pos = self.first_connected_pos.or(Some(pos)); self.nodes.push(node); InsertResult::Inserted } NodeStatus::Disconnected => { if self.nodes.is_full() { return InsertResult::Full } if let Some(ref mut p) = self.first_connected_pos { self.nodes.insert(*p, node); *p += 1; } else { self.nodes.push(node); } InsertResult::Inserted } } } /// Removes the node with the given key from the bucket, if it exists. pub fn remove(&mut self, key: &TKey) -> Option<(Node<TKey, TVal>, NodeStatus, Position)> { if let Some(pos) = self.position(key) { // Remove the node from its current position. let status = self.status(pos); let node = self.nodes.remove(pos.0); // Adjust `first_connected_pos` accordingly. match status { NodeStatus::Connected => if self.first_connected_pos.map_or(false, |p| p == pos.0) { if pos.0 == self.nodes.len() { // It was the last connected node. self.first_connected_pos = None } } NodeStatus::Disconnected => if let Some(ref mut p) = self.first_connected_pos { *p -= 1; } } Some((node, status, pos)) } else { None } } /// Returns the status of the node at the given position. pub fn status(&self, pos: Position) -> NodeStatus { if self.first_connected_pos.map_or(false, |i| pos.0 >= i) { NodeStatus::Connected } else { NodeStatus::Disconnected } } /// Checks whether the given position refers to a connected node. pub fn is_connected(&self, pos: Position) -> bool { self.status(pos) == NodeStatus::Connected } /// Gets the number of entries currently in the bucket. pub fn num_entries(&self) -> usize { self.nodes.len() } /// Gets the number of entries in the bucket that are considered connected. pub fn num_connected(&self) -> usize { self.first_connected_pos.map_or(0, |i| self.nodes.len() - i) } /// Gets the number of entries in the bucket that are considered disconnected. pub fn num_disconnected(&self) -> usize { self.nodes.len() - self.num_connected() } /// Gets the position of an node in the bucket. pub fn position(&self, key: &TKey) -> Option<Position> { self.nodes.iter().position(|p| p.key.as_ref() == key.as_ref()).map(Position) } /// Gets a mutable reference to the node identified by the given key. /// /// Returns `None` if the given key does not refer to a node in the /// bucket. pub fn get_mut(&mut self, key: &TKey) -> Option<&mut Node<TKey, TVal>> { self.nodes.iter_mut().find(move |p| p.key.as_ref() == key.as_ref()) } } #[cfg(test)] mod tests { use libp2p_core::PeerId; use rand::Rng; use std::collections::VecDeque; use super::*; use quickcheck::*; impl Arbitrary for KBucket<Key<PeerId>, ()> { fn arbitrary<G: Gen>(g: &mut G) -> KBucket<Key<PeerId>, ()> { let timeout = Duration::from_secs(g.gen_range(1, g.size() as u64)); let mut bucket = KBucket::<Key<PeerId>, ()>::new(timeout); let num_nodes = g.gen_range(1, K_VALUE.get() + 1); for _ in 0 .. num_nodes { let key = Key::new(PeerId::random()); let node = Node { key: key.clone(), value: () }; let status = NodeStatus::arbitrary(g); match bucket.insert(node, status) { InsertResult::Inserted => {} _ => panic!() } } bucket } } impl Arbitrary for NodeStatus { fn arbitrary<G: Gen>(g: &mut G) -> NodeStatus { if g.gen() { NodeStatus::Connected } else { NodeStatus::Disconnected } } } impl Arbitrary for Position { fn arbitrary<G: Gen>(g: &mut G) -> Position { Position(g.gen_range(0, K_VALUE.get())) } } // Fill a bucket with random nodes with the given status. fn fill_bucket(bucket: &mut KBucket<Key<PeerId>, ()>, status: NodeStatus) { let num_entries_start = bucket.num_entries(); for i in 0 .. K_VALUE.get() - num_entries_start { let key = Key::new(PeerId::random()); let node = Node { key, value: () }; assert_eq!(InsertResult::Inserted, bucket.insert(node, status)); assert_eq!(bucket.num_entries(), num_entries_start + i + 1); } } #[test] fn ordering() { fn prop(status: Vec<NodeStatus>) -> bool { let mut bucket = KBucket::<Key<PeerId>, ()>::new(Duration::from_secs(1)); // The expected lists of connected and disconnected nodes. let mut connected = VecDeque::new(); let mut disconnected = VecDeque::new(); // Fill the bucket, thereby populating the expected lists in insertion order. for status in status { let key = Key::new(PeerId::random()); let node = Node { key: key.clone(), value: () }; let full = bucket.num_entries() == K_VALUE.get(); match bucket.insert(node, status) { InsertResult::Inserted => { let vec = match status { NodeStatus::Connected => &mut connected, NodeStatus::Disconnected => &mut disconnected }; if full { vec.pop_front(); } vec.push_back((status, key.clone())); } _ => {} } } // Get all nodes from the bucket, together with their status. let mut nodes = bucket.iter() .map(|(n, s)| (s, n.key.clone())) .collect::<Vec<_>>(); // Split the list of nodes at the first connected node. let first_connected_pos = nodes.iter().position(|(s,_)| *s == NodeStatus::Connected); assert_eq!(bucket.first_connected_pos, first_connected_pos); let tail = first_connected_pos.map_or(Vec::new(), |p| nodes.split_off(p)); // All nodes before the first connected node must be disconnected and // in insertion order. Similarly, all remaining nodes must be connected // and in insertion order. nodes == Vec::from(disconnected) && tail == Vec::from(connected) } quickcheck(prop as fn(_) -> _); } #[test] fn full_bucket() { let mut bucket = KBucket::<Key<PeerId>, ()>::new(Duration::from_secs(1)); // Fill the bucket with disconnected nodes. fill_bucket(&mut bucket, NodeStatus::Disconnected); // Trying to insert another disconnected node fails. let key = Key::new(PeerId::random()); let node = Node { key, value: () }; match bucket.insert(node, NodeStatus::Disconnected) { InsertResult::Full => {}, x => panic!("{:?}", x) } // One-by-one fill the bucket with connected nodes, replacing the disconnected ones. for i in 0 .. K_VALUE.get() { let (first, first_status) = bucket.iter().next().unwrap(); let first_disconnected = first.clone(); assert_eq!(first_status, NodeStatus::Disconnected); // Add a connected node, which is expected to be pending, scheduled to // replace the first (i.e. least-recently connected) node. let key = Key::new(PeerId::random()); let node = Node { key: key.clone(), value: () }; match bucket.insert(node.clone(), NodeStatus::Connected) { InsertResult::Pending { disconnected } => assert_eq!(disconnected, first_disconnected.key), x => panic!("{:?}", x) } // Trying to insert another connected node fails. match bucket.insert(node.clone(), NodeStatus::Connected) { InsertResult::Full => {}, x => panic!("{:?}", x) } assert!(bucket.pending().is_some()); // Apply the pending node. let pending = bucket.pending_mut().expect("No pending node."); pending.set_ready_at(Instant::now() - Duration::from_secs(1)); let result = bucket.apply_pending(); assert_eq!(result, Some(AppliedPending { inserted: node.clone(), evicted: Some(first_disconnected) })); assert_eq!(Some((&node, NodeStatus::Connected)), bucket.iter().last()); assert!(bucket.pending().is_none()); assert_eq!(Some(K_VALUE.get() - (i + 1)), bucket.first_connected_pos); } assert!(bucket.pending().is_none()); assert_eq!(K_VALUE.get(), bucket.num_entries()); // Trying to insert another connected node fails. let key = Key::new(PeerId::random()); let node = Node { key, value: () }; match bucket.insert(node, NodeStatus::Connected) { InsertResult::Full => {}, x => panic!("{:?}", x) } } #[test] fn full_bucket_discard_pending() { let mut bucket = KBucket::<Key<PeerId>, ()>::new(Duration::from_secs(1)); fill_bucket(&mut bucket, NodeStatus::Disconnected); let (first, _) = bucket.iter().next().unwrap(); let first_disconnected = first.clone(); // Add a connected pending node. let key = Key::new(PeerId::random()); let node = Node { key: key.clone(), value: () }; if let InsertResult::Pending { disconnected } = bucket.insert(node, NodeStatus::Connected) { assert_eq!(&disconnected, &first_disconnected.key); } else { panic!() } assert!(bucket.pending().is_some()); // Update the status of the first disconnected node to be connected. bucket.update(&first_disconnected.key, NodeStatus::Connected); // The pending node has been discarded. assert!(bucket.pending().is_none()); assert!(bucket.iter().all(|(n,_)| &n.key != &key)); // The initially disconnected node is now the most-recently connected. assert_eq!(Some((&first_disconnected, NodeStatus::Connected)), bucket.iter().last()); assert_eq!(bucket.position(&first_disconnected.key).map(|p| p.0), bucket.first_connected_pos); assert_eq!(1, bucket.num_connected()); assert_eq!(K_VALUE.get() - 1, bucket.num_disconnected()); } #[test] fn bucket_update() { fn prop(mut bucket: KBucket<Key<PeerId>, ()>, pos: Position, status: NodeStatus) -> bool { let num_nodes = bucket.num_entries(); // Capture position and key of the random node to update. let pos = pos.0 % num_nodes; let key = bucket.nodes[pos].key.clone(); // Record the (ordered) list of status of all nodes in the bucket. let mut expected = bucket.iter().map(|(n,s)| (n.key.clone(), s)).collect::<Vec<_>>(); // Update the node in the bucket. bucket.update(&key, status); // Check that the bucket now contains the node with the new status, // preserving the status and relative order of all other nodes. let expected_pos = match status { NodeStatus::Connected => num_nodes - 1, NodeStatus::Disconnected => bucket.first_connected_pos.unwrap_or(num_nodes) - 1 }; expected.remove(pos); expected.insert(expected_pos, (key.clone(), status)); let actual = bucket.iter().map(|(n,s)| (n.key.clone(), s)).collect::<Vec<_>>(); expected == actual } quickcheck(prop as fn(_,_,_) -> _); } }