1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
#![cfg_attr(not(feature = "std"), no_std)]
use sp_inherents::{InherentIdentifier, ProvideInherent, InherentData, MakeFatalError};
use sp_runtime::traits::{One, Zero, SaturatedConversion};
use sp_std::{prelude::*, result, cmp, vec};
use frame_support::{decl_module, decl_storage, decl_error, ensure};
use frame_support::traits::Get;
use frame_support::weights::{DispatchClass};
use frame_system::{ensure_none, Trait as SystemTrait};
use sp_finality_tracker::{INHERENT_IDENTIFIER, FinalizedInherentData};
pub const DEFAULT_WINDOW_SIZE: u32 = 101;
pub const DEFAULT_REPORT_LATENCY: u32 = 1000;
pub trait Trait: SystemTrait {
type OnFinalizationStalled: OnFinalizationStalled<Self::BlockNumber>;
type WindowSize: Get<Self::BlockNumber>;
type ReportLatency: Get<Self::BlockNumber>;
}
decl_storage! {
trait Store for Module<T: Trait> as FinalityTracker {
RecentHints get(fn recent_hints) build(|_| vec![T::BlockNumber::zero()]): Vec<T::BlockNumber>;
OrderedHints get(fn ordered_hints) build(|_| vec![T::BlockNumber::zero()]): Vec<T::BlockNumber>;
Median get(fn median) build(|_| T::BlockNumber::zero()): T::BlockNumber;
Update: Option<T::BlockNumber>;
Initialized get(fn initialized) build(|_| false): bool;
}
}
decl_error! {
pub enum Error for Module<T: Trait> {
AlreadyUpdated,
BadHint,
}
}
decl_module! {
pub struct Module<T: Trait> for enum Call where origin: T::Origin {
type Error = Error<T>;
const WindowSize: T::BlockNumber = T::WindowSize::get();
const ReportLatency: T::BlockNumber = T::ReportLatency::get();
#[weight = (0, DispatchClass::Mandatory)]
fn final_hint(origin, #[compact] hint: T::BlockNumber) {
ensure_none(origin)?;
ensure!(!<Self as Store>::Update::exists(), Error::<T>::AlreadyUpdated);
ensure!(
frame_system::Module::<T>::block_number() >= hint,
Error::<T>::BadHint,
);
<Self as Store>::Update::put(hint);
}
fn on_finalize() {
Self::update_hint(<Self as Store>::Update::take())
}
}
}
impl<T: Trait> Module<T> {
fn update_hint(hint: Option<T::BlockNumber>) {
if !Self::initialized() {
<Self as Store>::RecentHints::put(vec![T::BlockNumber::zero()]);
<Self as Store>::OrderedHints::put(vec![T::BlockNumber::zero()]);
<Self as Store>::Median::put(T::BlockNumber::zero());
<Self as Store>::Initialized::put(true);
}
let mut recent = Self::recent_hints();
let mut ordered = Self::ordered_hints();
let window_size = cmp::max(T::BlockNumber::one(), T::WindowSize::get());
let hint = hint.unwrap_or_else(|| recent.last()
.expect("always at least one recent sample; qed").clone()
);
{
let to_prune = (recent.len() + 1).saturating_sub(window_size.saturated_into::<usize>());
for drained in recent.drain(..to_prune) {
let idx = ordered.binary_search(&drained)
.expect("recent and ordered contain the same items; qed");
ordered.remove(idx);
}
}
let ordered_idx = ordered.binary_search(&hint)
.unwrap_or_else(|idx| idx);
ordered.insert(ordered_idx, hint);
recent.push(hint);
let two = T::BlockNumber::one() + T::BlockNumber::one();
let median = {
let len = ordered.len();
assert!(len > 0, "pruning dictated by window_size which is always saturated at 1; qed");
if len % 2 == 0 {
let a = ordered[len / 2];
let b = ordered[(len / 2) - 1];
(a + b) / two
} else {
ordered[len / 2]
}
};
let our_window_size = recent.len() as u32;
<Self as Store>::RecentHints::put(recent);
<Self as Store>::OrderedHints::put(ordered);
<Self as Store>::Median::put(median);
if T::BlockNumber::from(our_window_size) == window_size {
let now = frame_system::Module::<T>::block_number();
let latency = T::ReportLatency::get();
let delay = latency + (window_size / two);
if median + delay <= now {
T::OnFinalizationStalled::on_stalled(window_size - T::BlockNumber::one(), median);
}
}
}
}
#[impl_trait_for_tuples::impl_for_tuples(30)]
pub trait OnFinalizationStalled<N> {
fn on_stalled(further_wait: N, median: N);
}
impl<T: Trait> ProvideInherent for Module<T> {
type Call = Call<T>;
type Error = MakeFatalError<()>;
const INHERENT_IDENTIFIER: InherentIdentifier = INHERENT_IDENTIFIER;
fn create_inherent(data: &InherentData) -> Option<Self::Call> {
if let Ok(final_num) = data.finalized_number() {
Self::recent_hints().last().and_then(|last| if last == &final_num {
None
} else {
Some(Call::final_hint(final_num))
})
} else {
None
}
}
fn check_inherent(_call: &Self::Call, _data: &InherentData) -> result::Result<(), Self::Error> {
Ok(())
}
}
#[cfg(test)]
mod tests {
use super::*;
use sp_io::TestExternalities;
use sp_core::H256;
use sp_runtime::{
testing::Header,
traits::{BlakeTwo256, IdentityLookup},
Perbill,
};
use frame_support::{
assert_ok, impl_outer_origin, parameter_types,
weights::Weight,
traits::OnFinalize,
};
use frame_system as system;
use std::cell::RefCell;
#[derive(Clone, PartialEq, Debug)]
pub struct StallEvent {
at: u64,
further_wait: u64,
}
#[derive(Clone, Eq, PartialEq)]
pub struct Test;
impl_outer_origin! {
pub enum Origin for Test where system = frame_system {}
}
thread_local! {
static NOTIFICATIONS: RefCell<Vec<StallEvent>> = Default::default();
}
pub struct StallTracker;
impl OnFinalizationStalled<u64> for StallTracker {
fn on_stalled(further_wait: u64, _median: u64) {
let now = System::block_number();
NOTIFICATIONS.with(|v| v.borrow_mut().push(StallEvent { at: now, further_wait }));
}
}
parameter_types! {
pub const BlockHashCount: u64 = 250;
pub const MaximumBlockWeight: Weight = 1024;
pub const MaximumBlockLength: u32 = 2 * 1024;
pub const AvailableBlockRatio: Perbill = Perbill::one();
}
impl system::Trait for Test {
type BaseCallFilter = ();
type Origin = Origin;
type Index = u64;
type BlockNumber = u64;
type Call = ();
type Hash = H256;
type Hashing = BlakeTwo256;
type AccountId = u64;
type Lookup = IdentityLookup<u64>;
type Header = Header;
type Event = ();
type BlockHashCount = BlockHashCount;
type MaximumBlockWeight = MaximumBlockWeight;
type DbWeight = ();
type BlockExecutionWeight = ();
type ExtrinsicBaseWeight = ();
type MaximumExtrinsicWeight = MaximumBlockWeight;
type AvailableBlockRatio = AvailableBlockRatio;
type MaximumBlockLength = MaximumBlockLength;
type Version = ();
type PalletInfo = ();
type AccountData = ();
type OnNewAccount = ();
type OnKilledAccount = ();
type SystemWeightInfo = ();
}
parameter_types! {
pub const WindowSize: u64 = 11;
pub const ReportLatency: u64 = 100;
}
impl Trait for Test {
type OnFinalizationStalled = StallTracker;
type WindowSize = WindowSize;
type ReportLatency = ReportLatency;
}
type System = system::Module<Test>;
type FinalityTracker = Module<Test>;
#[test]
fn median_works() {
let t = system::GenesisConfig::default().build_storage::<Test>().unwrap();
TestExternalities::new(t).execute_with(|| {
FinalityTracker::update_hint(Some(500));
assert_eq!(FinalityTracker::median(), 250);
assert!(NOTIFICATIONS.with(|n| n.borrow().is_empty()));
});
}
#[test]
fn notifies_when_stalled() {
let t = system::GenesisConfig::default().build_storage::<Test>().unwrap();
TestExternalities::new(t).execute_with(|| {
let mut parent_hash = System::parent_hash();
for i in 2..106 {
System::initialize(
&i,
&parent_hash,
&Default::default(),
&Default::default(),
Default::default()
);
FinalityTracker::on_finalize(i);
let hdr = System::finalize();
parent_hash = hdr.hash();
}
assert_eq!(
NOTIFICATIONS.with(|n| n.borrow().clone()),
vec![StallEvent { at: 105, further_wait: 10 }]
)
});
}
#[test]
fn recent_notifications_prevent_stalling() {
let t = system::GenesisConfig::default().build_storage::<Test>().unwrap();
TestExternalities::new(t).execute_with(|| {
let mut parent_hash = System::parent_hash();
for i in 2..106 {
System::initialize(
&i,
&parent_hash,
&Default::default(),
&Default::default(),
Default::default(),
);
assert_ok!(FinalityTracker::final_hint(Origin::none(), i - 1));
FinalityTracker::on_finalize(i);
let hdr = System::finalize();
parent_hash = hdr.hash();
}
assert!(NOTIFICATIONS.with(|n| n.borrow().is_empty()));
});
}
}